-
Notifications
You must be signed in to change notification settings - Fork 218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Hi,
Thanks for providing that library.
To ease the usage and the testing it would be good to allow your users to update the endpoint after the client initialization.
This would allow me at least to avoid having to use global variables instead of constants or having to expose in my client the API URL that is not changing except in the tests.
https://github.com/VEVO/slab-go/blob/master/slab/slab_test.go#L32
As
endpointis currently unexported that won't break any dependent codes either.Thanks for your help,
Joseph