-
Notifications
You must be signed in to change notification settings - Fork 204
fix(ios): trigger BLE scan when entering ScanningEquipment view#25
Open
Flo5k5 wants to merge 1 commit into
Open
fix(ios): trigger BLE scan when entering ScanningEquipment view #25Flo5k5 wants to merge 1 commit into
Flo5k5 wants to merge 1 commit into
Conversation
The upstream .task{} block was empty, which meant BlufiUtil.startScan()
was never called after the user reached the QR scan page. Consequence:
after scanning the QR, readCodeString() calls openBlufi() to set the
discovery callback, but there's no live scan feeding it - the iPhone
never sees the ESP32 in advertising mode and the app stays stuck on
the main view.
Call getPermission() in .task (which in turn calls getBlueAndWifiInfo()
and startScan() once the user grants location permission, as iOS
requires for BLE scans).
This is a real bug in the open-source app that should also land
upstream as PR m5stack#9. For now it lives on self-host to unblock our
provisioning immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream .task{} block was empty, which meant BlufiUtil.startScan()
was never called after the user reached the QR scan page. Consequence:
after scanning the QR, readCodeString() calls openBlufi() to set the
discovery callback, but there's no live scan feeding it - the iPhone
never sees the ESP32 in advertising mode and the app stays stuck on
the main view.
Call getPermission() in .task (which in turn calls getBlueAndWifiInfo()
and startScan() once the user grants location permission, as iOS
requires for BLE scans).
This is a real bug in the open-source app that should also land
upstream as PR #9. For now it lives on self-host to unblock our
provisioning immediately.