-
-
Notifications
You must be signed in to change notification settings - Fork 151
Conversation
cf2b12e to
1e5023c
Compare
1e5023c to
f243576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping this causes ci to fail as the formatter has changed, please format the entire codebase so the tests can run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we importing this and not List$Empty$const, it's the reason for the entire PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an internal detail that shouldn't be depended on I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here (:
In Gleam 1.18 the compiler started generating a singleton value for the empty list, so this optimisation won't be needed anymore