Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Grafana Dashboard #116

Open
gianick wants to merge 9 commits into main
base: main
Choose a base branch
Loading
from Dashboard
Open

Grafana Dashboard #116

gianick wants to merge 9 commits into main from Dashboard

Conversation

Copy link
Contributor

@gianick gianick commented Aug 23, 2023

No description provided.

Copy link

@thinkmorestupidless thinkmorestupidless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i run docker compose up it brings everything up but in Grafana I don't see any data source or dashboards, they should be automatically configured in Grafana but for some reason they're missing.

I removed all containers before running so it's not because of any pre-existing Grafana container.

@@ -83,7 +83,7 @@ SLF4J: See also http://www.slf4j.org/codes.html#replay
man [e] > Scala 2 to Scala 3 > sudoku solver initial state >
```

- Run the Sodukosolver by executing the `runSolver` command from the `sbt` prompt.
- Run the Sudokusolver by executing the `runSolver` command from the `sbt` prompt.
Copy link

@thinkmorestupidless thinkmorestupidless Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -42,11 +43,12 @@ object Main {
object SudokuSolverMain {

def main(args: Array[String]): Unit = {
Kamon.init()

val system = ActorSystem[NotUsed](Main(), "sudoku-solver-system")

println(s"${GREEN}Hit RETURN to stop solver${RESET}")
Copy link

@thinkmorestupidless thinkmorestupidless Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run / fork := true is required for Kamon instrumentation to work (if the application doesn't run in a forked JVM then the instrumentation agent can't be attached so no metrics are sent anywhere)

BUT, this stops the application blocking on StdIn.readline() - hence the need to remove the two lines below (otherwise it just falls through to system.terminate()) - not sure why, seems to be a known thing.

We should remove them completely rather than just commenting out, and probably remove the println as well as it's not necessary either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove them completely rather than just commenting out, and probably remove the println as well as it's not necessary either.

Yes, please remove it as needed

gianick reacted with thumbs up emoji
@gianick gianick force-pushed the Dashboard branch 2 times, most recently from 2af1ff0 to 2cfc044 Compare August 23, 2023 09:31
@gianick gianick changed the title (削除) Dashboard (削除ここまで) (追記) Grafana Dashboard (追記ここまで) Aug 24, 2023
@gianick gianick marked this pull request as ready for review August 24, 2023 09:23
@gianick gianick force-pushed the Dashboard branch 2 times, most recently from 85309ba to 22a913e Compare August 30, 2023 13:31
eloots and others added 2 commits September 1, 2023 09:24 
- Removed some graphs that are not relevant to the demo
- Changed dashboard layout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@eloots eloots eloots left review comments

@thinkmorestupidless thinkmorestupidless thinkmorestupidless left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /