Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

OAuth updates for third party login options. #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FalkWolsky merged 7 commits into lowcoder-org:dev from raheeliftikhar5:oauth-fe
Oct 9, 2023

Conversation

Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 commented Sep 27, 2023

Proposed changes

This PR updates OAuth flow to handle organisation based authentications. Organisation admin can enable third party login options e.g. Google/Github etc and invited users or organisation members can login using available options.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Sep 27, 2023
edited
Loading

!!️ Deploy request for lowcoder-cloud rejected.

Name Link
🔨 Latest commit 8b01d78

@FalkWolsky FalkWolsky added the Enhancement New feature or request label Sep 28, 2023
@raheeliftikhar5 raheeliftikhar5 changed the base branch from main to dev September 29, 2023 12:10
Copy link

netlify bot commented Oct 2, 2023
edited
Loading

Deploy Preview for branchit-lowcoder-test ready!

Name Link
🔨 Latest commit 451cb73
🔍 Latest deploy log https://app.netlify.com/sites/branchit-lowcoder-test/deploys/651a718d8268830007322747
😎 Deploy Preview https://deploy-preview-389--branchit-lowcoder-test.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@raheeliftikhar5 raheeliftikhar5 changed the title (削除) [WIP] OAuth updates for third party login options. (削除ここまで) (追記) OAuth updates for third party login options. (追記ここまで) Oct 2, 2023
Copy link

netlify bot commented Oct 6, 2023

👷 Deploy request for branchit-lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8e14e7b

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive. Thank you very much for this wonderful contribution!

@FalkWolsky FalkWolsky merged commit 213381c into lowcoder-org:dev Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FalkWolsky FalkWolsky FalkWolsky approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /