Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Layout component fixes #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron1604 merged 2 commits into lowcoder-org:main from raheeliftikhar5:layout-component-fixes
Aug 28, 2023

Conversation

Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 commented Aug 25, 2023

Proposed changes

Fixed these issues in layout component.

  • Allow user to set min-width in a row without overflow
  • Set default value of 'Match Column Height' to True

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Aug 25, 2023
edited
Loading

Deploy Preview for lowcoder-cloud ready!

Name Link
🔨 Latest commit 1e769a2
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/64e8863dfc1e730008f92edc
😎 Deploy Preview https://deploy-preview-349--lowcoder-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aaron1604 aaron1604 merged commit 8beddaa into lowcoder-org:main Aug 28, 2023
@raheeliftikhar5 raheeliftikhar5 deleted the layout-component-fixes branch November 29, 2023 10:48
@raheeliftikhar5 raheeliftikhar5 restored the layout-component-fixes branch November 29, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aaron1604 aaron1604 aaron1604 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /