Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Antd Upgrade #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FalkWolsky merged 14 commits into lowcoder-org:main from raheeliftikhar5:antd-upgrade
Jul 28, 2023
Merged

Antd Upgrade #307

FalkWolsky merged 14 commits into lowcoder-org:main from raheeliftikhar5:antd-upgrade
Jul 28, 2023

Conversation

Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 commented Jul 24, 2023
edited
Loading

Proposed changes

Updated antd version from v4 to v5. Major changes incudes:

  • Updated antd version
  • Updated antd dependencies
  • Replaced momentJS with dayJS
  • Updated Dropdown menu
  • Updated confirm modal
  • Global instances for message, modal and notifications
  • Component props updates

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Jul 24, 2023
edited
Loading

👷 Deploy request for classy-bombolone-94aec0 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b025eba

Copy link

netlify bot commented Jul 24, 2023
edited
Loading

Deploy Preview for lowcoder-cloud failed.

Name Link
🔨 Latest commit b025eba
🔍 Latest deploy log https://app.netlify.com/projects/lowcoder-cloud/deploys/64c2b9ba44095e00079fcd40

@raheeliftikhar5 raheeliftikhar5 changed the title (削除) Antd upgrade (削除ここまで) (追記) [WIP] Antd Upgrade (追記ここまで) Jul 24, 2023
@FalkWolsky FalkWolsky marked this pull request as ready for review July 27, 2023 18:38
@FalkWolsky FalkWolsky changed the title (削除) [WIP] Antd Upgrade (削除ここまで) (追記) Antd Upgrade (追記ここまで) Jul 28, 2023
@FalkWolsky FalkWolsky self-requested a review July 28, 2023 16:50
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive contribution. Thank you very much, Raheel!

raheeliftikhar5 reacted with thumbs up emoji
@FalkWolsky FalkWolsky merged commit 70ea444 into lowcoder-org:main Jul 28, 2023
@raheeliftikhar5 raheeliftikhar5 deleted the antd-upgrade branch November 29, 2023 10:49
@raheeliftikhar5 raheeliftikhar5 restored the antd-upgrade branch November 29, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FalkWolsky FalkWolsky FalkWolsky approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /