-
Notifications
You must be signed in to change notification settings - Fork 271
Fix_Optimize_JSON_Lottie_Component #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix_Optimize_JSON_Lottie_Component #294
Conversation
1.move svg to folder lowcoder-design 2.All options support multiple languages 3.add attribute keepLastFrame,Prevent components from becoming blank 4.change backgroundcolor follow the canvas color 5.delete MARGIN and PADDING style
✅ Deploy Preview for lowcoder-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy request for classy-bombolone-94aec0 pending review.Visit the deploys page to approve it
|
That is a valuable contribution. Thank you very much!
We need to check about margin / padding, as we introduced it by the current changes.
@aaron1604 will please have a look and decide.
image
In fact, in the current version, the padding/margin setting is invalid, and during my testing, the component looks very unattractive after setting padding/margin because if you want to adjust the animation size, you can directly adjust the component size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your valuable contribution! The "stop at last frame" is truly a good addition. We also will take care of fixing the margin/padding as you advise.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
xin the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
xin the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.