Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add possibility to turn off rate limit filter #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludomikula merged 1 commit into main from enhance_rate_limit_configuration
Jul 14, 2023

Conversation

Copy link
Collaborator

@ludomikula ludomikula commented Jul 14, 2023

Proposed changes

In bigger deployments it's better to do rate limiting on the loadbalancer instead of directly in the application.
With this change, when default.api-rate-limit is set to a number lower then 1, rate limiter is disabled completely.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

Copy link

netlify bot commented Jul 14, 2023
edited
Loading

Deploy Preview for classy-bombolone-94aec0 canceled.

Name Link
🔨 Latest commit 4048b2e
🔍 Latest deploy log https://app.netlify.com/sites/classy-bombolone-94aec0/deploys/64b112b288a8570008e41deb

@ludomikula ludomikula merged commit e699269 into main Jul 14, 2023
@ludomikula ludomikula deleted the enhance_rate_limit_configuration branch July 14, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aq-ikhwa-tech aq-ikhwa-tech aq-ikhwa-tech approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /