-
Notifications
You must be signed in to change notification settings - Fork 268
Add App-Specific Favicon & PWA Install Icon Support #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ackend endpoints for icon retrieval and manifest generation.
👷 Deploy request for lowcoder-test pending review.Visit the deploys page to approve it
|
...wa-icon-support
Hello, here is my third PR attempt to this feature. Please let me know if this can safely be merged or if I have to modify anything else. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements app-specific favicon and PWA icon functionality, allowing each Lowcoder application to have its own visual identity in browser tabs and when installed as a Progressive Web App (PWA).
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.✨ Features
Frontend Changes
Backend Changes
Documentation
🔧 Console Error Fixes
During development, several console errors were identified and resolved:
📁 Files Modified
Core Feature Files
client/packages/lowcoder/src/app.tsx
- Removed global favicon, added per-route handlingclient/packages/lowcoder/src/pages/editor/editorView.tsx
- Added app-specific favicon injectionclient/packages/lowcoder/src/pages/ApplicationV2/index.tsx
- Added favicon handling for admin viewclient/packages/lowcoder/src/comps/comps/multiIconDisplay.tsx
- Enhanced icon display and error handlingclient/packages/lowcoder/src/util/iconConversionUtils.ts
- New utility for icon format conversionserver/api-service/lowcoder-server/src/main/java/org/lowcoder/api/application/ApplicationController.java
- Added icon serving endpointserver/api-service/lowcoder-server/src/main/java/org/lowcoder/api/framework/security/SecurityConfig.java
- Updated security for icon accessserver/api-service/lowcoder-server/src/main/java/org/lowcoder/api/application/AppIconController.java
- New icon controllerdocs/build-applications/app-editor/pwa-icons-and-favicons.md
- New documentation🚀 Benefits
🧪 Testing