-
Notifications
You must be signed in to change notification settings - Fork 272
[Feat]: Add Time-Only Column Type to the Table Component #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.13.33 to 3.22.0. - [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases) - [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst) - [Commits](snowflakedb/snowflake-jdbc@v3.13.33...v3.22.0) --- updated-dependencies: - dependency-name: net.snowflake:snowflake-jdbc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
...-plugins/snowflakePlugin/net.snowflake-snowflake-jdbc-3.22.0
...en/server/api-service/lowcoder-plugins/snowflakePlugin/net.snowflake-snowflake-jdbc-3.22.0 Bump net.snowflake:snowflake-jdbc from 3.13.33 to 3.22.0 in /server/api-service/lowcoder-plugins/snowflakePlugin
👷 Deploy request for lowcoder-cloud pending review.Visit the deploys page to approve it
|
Hey Faran, following are the issues i found in your PR:
- When we select column type "Time" and there is no column value, it should show empty text in table instead of default date.
- When we make this "Time" column editable and user try to edit by double clicking, it should show only time picker instead of data and time picker. Kindly check Ant design's data picker to see what props should we pass to show only time picker https://ant.design/components/date-picker
- When i select value from current data/time picker, it should show the value in the column but it shows empty.
Please check these issues, and let me know if there is any question. Thanks
raheeliftikhar5
raheeliftikhar5
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments.
❌ Deploy Preview for lowcoder-test failed.
|
@raheeliftikhar5 I have addressed the requested changes. Please review again when you have time. Thanks!
@raheeliftikhar5
raheeliftikhar5
changed the title
(削除) [Feat]: Add Time-Only Column Type to the Table Component (#1549) (削除ここまで)
(追記) [Feat]: Add Time-Only Column Type to the Table Component (追記ここまで)
Mar 3, 2025
raheeliftikhar5
raheeliftikhar5
approved these changes
Mar 11, 2025
@raheeliftikhar5
raheeliftikhar5
merged commit Mar 11, 2025
255d870
into
lowcoder-org:dev
3 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Proposed changes
This feature adds a "Time-only" column type to the Table component, ensuring users can input only time values. It was built using the existing DateTime component and reuses the suffix/prefix icon from SimpleTextComp
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.