-
Notifications
You must be signed in to change notification settings - Fork 271
Patch 2 #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 2 #1249
Conversation
integrated entire https://custom-component.majiang.co/index.html to fix functionality with custom components and remove external dependency
👷 Deploy request for lowcoder-cloud pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please comment what your changes would have as effect and how you intend to change the custom component. From pure code reading - we did not understand fully what your change is about. You can use the standard description area of the PR / Merge Request to describe your change. Than you very much in advance.
As a second wish ... we always only raise PRs to /dev not to /main.
From there we run our tests and only at a release we merge to /main. Please change the destination of the PR to /dev. That would be helpful!
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.