Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Patch 2 #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
konstchri wants to merge 12 commits into lowcoder-org:main from konstchri:patch-2
Closed

Patch 2 #1249

konstchri wants to merge 12 commits into lowcoder-org:main from konstchri:patch-2

Conversation

Copy link

@konstchri konstchri commented Oct 19, 2024

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

konstchri added 11 commits May 30, 2023 15:30
integrated entire https://custom-component.majiang.co/index.html to fix functionality with custom components and remove external dependency
Copy link

netlify bot commented Oct 19, 2024
edited
Loading

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit be2942b

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please comment what your changes would have as effect and how you intend to change the custom component. From pure code reading - we did not understand fully what your change is about. You can use the standard description area of the PR / Merge Request to describe your change. Than you very much in advance.

As a second wish ... we always only raise PRs to /dev not to /main.
From there we run our tests and only at a release we merge to /main. Please change the destination of the PR to /dev. That would be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FalkWolsky FalkWolsky FalkWolsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /