-
Notifications
You must be signed in to change notification settings - Fork 276
Concurrency user display #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Concurrency user display #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lowcoder-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If a User A edit an Lowcoder app, and another User B also opens the very same app to edit, both would end up in concurrent overwriting of the app Edit states - as Lowcoder as for now only was made for a single-user as Editor.
In our first attempt to support better multi-user (Editor) experience, we introduce with this PR a optimistic locking strategy. We think it is not a true way to go to try to get a real "multi-user interactivity" for app editing to work. It is not really the case that 2 people same time want collaborative want to edit a single app. Still it can happen that by accident and as rather rare case 2 users open an app independently in the same time.
In this PR we introduce a display for "User B" to get a notice, that a "User A" is editing the app.
After a time window of 3 minutes of inactivity of User A - the lock will be removed and User B can go on to edit the app.
Types of changes
Checklist