Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update loaders #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FalkWolsky merged 12 commits into dev from update-loaders
Sep 8, 2024
Merged

Update loaders #1146

FalkWolsky merged 12 commits into dev from update-loaders
Sep 8, 2024

Conversation

Copy link
Contributor

@FalkWolsky FalkWolsky commented Sep 5, 2024

Proposed changes

This PR introduces changes to the waiting indicator display. We harmonized them to a single type and added a control switch for the App Creator to control the behaviour.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Sep 5, 2024
edited
Loading

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 3a581a9
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66da051353986800087984d4
😎 Deploy Preview https://deploy-preview-1146--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 5, 2024
edited
Loading

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit ae1cb0e
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66ddd6be9f4c5c00089efeca
😎 Deploy Preview https://deploy-preview-1146--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky merged commit 1e3d6a6 into dev Sep 8, 2024
7 checks passed
@FalkWolsky FalkWolsky deleted the update-loaders branch September 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /