-
Notifications
You must be signed in to change notification settings - Fork 276
Fix previous incomplete FirebirdSQL PR #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for lowcoder-test pending review.Visit the deploys page to approve it
|
Also, I'm not sure if I should include yarn.lock file in these commits?
Should I run sth like: rm -rf node_nodules && yarn install before that?
@ludomikula
ludomikula
force-pushed
the
dev
branch
from
September 2, 2024 15:01
ca94792 to
44bbbf4
Compare
@mat02
mat02
changed the title
(削除) Fix missing await (削除ここまで)
(追記) Fix previous incomplete FirebirdSQL PR (追記ここまで)
Sep 3, 2024
ludomikula
ludomikula
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just noticed that after rebase I accidentaly pushed a version with missing 'await' statement ...
This PR fixes that issue, sorry for the hassle.