-
Notifications
You must be signed in to change notification settings - Fork 170
Open
Conversation
...he condition.
wsmoses
wsmoses
reviewed
Jul 18, 2024
(!(fix(t.getDefiningOp()->getOperand(0), false) &&
fix(t.getDefiningOp()->getOperand(1), false)))) ||
(t.getDefiningOp<DivSIOp>() &&
((t.getDefiningOp<DivUIOp>() || t.getDefiningOp<DivSIOp>()) &&
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If doing a divui I wonder if we should also check that the divisor is positive. The AffineExpr constraint assumes signed division iirc, which is why we originally didn't include.
Of course crashing is far worse, so we don't want that to occur.
sBobHuang
commented
Jul 18, 2024
Author
Thank you very much for the feedback. I did not consider the sign issue with AffineExpr before. I will try another fix. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View details of issue 421 .