-
Notifications
You must be signed in to change notification settings - Fork 240
Return 503 for OPTIONS when SIP node is not healthy (#764) - #770
Open
lixuanqun wants to merge 2 commits into
Open
Return 503 for OPTIONS when SIP node is not healthy (#764) #770lixuanqun wants to merge 2 commits into
lixuanqun wants to merge 2 commits into
Conversation
SIP proxies often probe backends with OPTIONS. Always answering 200 kept draining nodes in the pool. Mirror CreateSIPParticipant/HTTP health and answer 503 unless HealthOK. Also reject new inbound INVITEs while unhealthy; in-dialog re-INVITEs for active calls still succeed. Co-authored-by: li xuanqun <793005378@qq.com>
devin-ai-integration[bot]
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
...UnderLoad Out-of-dialog OPTIONS still return 503 when unhealthy. In-dialog OPTIONS for active calls answer 200 during drain so SBCs don't tear down live sessions. New INVITEs are rejected only when Stopped/NotStarted, not on transient HealthUnderLoad (which broke CI on busy runners). Co-authored-by: li xuanqun <793005378@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #770 +/- ## ========================================== + Coverage 65.25% 65.98% +0.73% ========================================== Files 51 41 -10 Lines 6588 7968 +1380 ========================================== + Hits 4299 5258 +959 - Misses 1915 2226 +311 - Partials 374 484 +110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIP proxies often probe backends with OPTIONS. Always answering 200 kept draining nodes in the pool. Mirror CreateSIPParticipant/HTTP health and answer 503 unless HealthOK. Also reject new inbound INVITEs while unhealthy; in-dialog re-INVITEs for active calls still succeed.