-
Notifications
You must be signed in to change notification settings - Fork 138
Text/byte stream handling bug, documentation issues - #379
Conversation
Fix for RuntimeWarning: coroutine 'RoomManager.handle_text_stream' was never awaited This occurs when a message is received from a text stream.
CLA assistant check
All committers have signed the CLA.
davidzhao
commented
Mar 1, 2025
@onorabil thanks for the fix. we've got a couple of CI failures, do you mind taking a look?
onorabil
commented
Mar 2, 2025
You're welcome! 1/2 failures fixed, the second one appears to be github actions related / branch not in livekit/python-sdks.
2025年03月01日T23:26:57.8896834Z ##[group]Run actions/checkout@v3
2025年03月01日T23:26:57.8897662Z with:
2025年03月01日T23:26:57.8898053Z submodules: true
2025年03月01日T23:26:57.8898473Z ref: patch-1 #this branch is not available in livekit/python-sdks
2025年03月01日T23:26:57.8898908Z repository: livekit/python-sdks
...
2025年03月01日T23:26:58.1860097Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/patch-1*:refs/remotes/origin/patch-1* +refs/tags/patch-1*:refs/tags/patch-1* #main issue
2025年03月01日T23:26:58.4375152Z The process '/usr/bin/git' failed with exit code 1
This was done on purpose, the responsibility for asynchronous management for the handler was supposed to live in user land, so having a synchronous callback and using asyncio task handling within the callback.
the docs need an update to reflect that.
curious to hear @theomonnom take on this
Fix for RuntimeWarning: coroutine 'RoomManager.handle_text_stream' was never awaited This occurs when a message is received from a text (or byte) stream.
As shown in the documentation here, https://docs.livekit.io/home/client/data/text-streams/ a stream should register a handle like this:
But this results in the error above.
Furthmore, some documentation from the text-streams page above is wrong.
f' ID: {info.id}\n'should readf' ID: {info.stream_id}\n'room.registerTextStreamHandler('my-topic', (reader, participantInfo) => {should readroom.registerTextStreamHandler('my-topic', async (reader, participantInfo) => {