-
Notifications
You must be signed in to change notification settings - Fork 40
set-test-tokens: use env vars as default for secret/key/url - #256
Open
stephen-derosa wants to merge 1 commit into
Open
set-test-tokens: use env vars as default for secret/key/url #256stephen-derosa wants to merge 1 commit into
stephen-derosa wants to merge 1 commit into
Conversation
stephen-derosa
requested review from
a team and
xianshijing-lk
as code owners
September 8, 2026 14:34
devin-ai-integration[bot]
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stephen-derosa
force-pushed
the
sderosa/set-test-tokens-env-vars-are-default
branch
from
September 8, 2026 20:58
46afef4 to
2023910
Compare
alan-george-lk
alan-george-lk
approved these changes
Sep 9, 2026
LIVEKIT_URL="ws://localhost:7880"
_grant_json='{"canPublish":true,"canSubscribe":true,"canPublishData":true}'
echo "set_test_tokens: Using LIVEKIT_URL: $LIVEKIT_URL" >&2
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we avoid printing here? We have plenty of logs across SDK layers/end products (ROS Portal) that log which URL is being connected to. I also run individual tests often and call into this script first, so I'll be getting more output
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need some log to indicate the creds being used so we can prevent devs from using the wrong creds. I could change it to "using local server" or "using cloud server" ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.