Skip to content

Navigation Menu

Sign in
Sign up

Update default.conf.sample to deny dotfile access - #535

Open
nemchik wants to merge 3 commits into
previous from
deny-dotfile-access-previous
Open

Update default.conf.sample to deny dotfile access #535
nemchik wants to merge 3 commits into
previous from
deny-dotfile-access-previous

Conversation

@nemchik

@nemchik nemchik commented Feb 8, 2026

Copy link
Copy Markdown
Member

No description provided. 

Signed-off-by: Eric Nemchik <eric@nemchik.com>

Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.8-pkg-9de873a0-dev-8101d94a8d6907d65105581635d91f3728d73087-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.8-pkg-9de873a0-dev-8101d94a8d6907d65105581635d91f3728d73087-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-32.0.8-pkg-9de873a0-dev-8101d94a8d6907d65105581635d91f3728d73087-pr-535 ❌
arm64v8-previous-32.0.8-pkg-9de873a0-dev-8101d94a8d6907d65105581635d91f3728d73087-pr-535 ✅

Copilot AI review requested due to automatic review settings May 4, 2026 20:53
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bundled Nginx sample site config to more broadly block access to dotfiles, and records the change in the generated README changelog source (readme-vars.yml).

Changes:

  • Update default.conf.sample to deny requests to dotfile paths (and suppress related logging).
  • Add a changelog entry advising existing users to update their Nginx site config.
  • Adjust the existing "Rebase to Alpine 3.22." changelog entry date.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
root/defaults/nginx/site-confs/default.conf.sample Expands dotfile blocking behavior in the sample Nginx server config.
readme-vars.yml Adds a changelog entry describing the dotfile access change (and modifies an older changelog date).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +176 to +181
# deny access to all dotfiles
location ~ /\. {
deny all;
log_not_found off;
access_log off;
return 404;
location ~ /\.ht {
# deny access to all dotfiles
location ~ /\. {
deny all;
Comment thread readme-vars.yml
changelogs:
- {date: "14.10.25:", desc: "Rebase to Alpine 3.22."}
- {date: "08.02.26:", desc: "Existing users should update: site-confs/default.conf - Deny access to all dotfiles."}
- {date: "10.07.25:", desc: "Rebase to Alpine 3.22."}

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.9-pkg-3db640cb-dev-3c2743f677cd9e1c2b6dbbd1eb06b3b31dd9ba71-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.9-pkg-3db640cb-dev-3c2743f677cd9e1c2b6dbbd1eb06b3b31dd9ba71-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-32.0.9-pkg-3db640cb-dev-3c2743f677cd9e1c2b6dbbd1eb06b3b31dd9ba71-pr-535 ✅
arm64v8-previous-32.0.9-pkg-3db640cb-dev-3c2743f677cd9e1c2b6dbbd1eb06b3b31dd9ba71-pr-535 ✅ 

Signed-off-by: Eric Nemchik <eric@nemchik.com>

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.9-pkg-d7059a54-dev-c5b99814c1c84ebbd1d7166c2bc92be1b4af84c2-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.9-pkg-d7059a54-dev-c5b99814c1c84ebbd1d7166c2bc92be1b4af84c2-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-32.0.9-pkg-d7059a54-dev-c5b99814c1c84ebbd1d7166c2bc92be1b4af84c2-pr-535 ✅
arm64v8-previous-32.0.9-pkg-d7059a54-dev-c5b99814c1c84ebbd1d7166c2bc92be1b4af84c2-pr-535 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit c80bd46 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.11-pkg-97fd5ae0-dev-c80bd4689f7b4269927dc2a7147534aac288d14c-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-32.0.11-pkg-97fd5ae0-dev-c80bd4689f7b4269927dc2a7147534aac288d14c-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-32.0.11-pkg-97fd5ae0-dev-c80bd4689f7b4269927dc2a7147534aac288d14c-pr-535 ✅
arm64v8-previous-32.0.11-pkg-97fd5ae0-dev-c80bd4689f7b4269927dc2a7147534aac288d14c-pr-535 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit cb0f63f :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-33.0.6-pkg-a3d7a288-dev-cb0f63fd34cb0788d734dbd6eca21beac27d4307-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-33.0.6-pkg-a3d7a288-dev-cb0f63fd34cb0788d734dbd6eca21beac27d4307-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-33.0.6-pkg-a3d7a288-dev-cb0f63fd34cb0788d734dbd6eca21beac27d4307-pr-535 ✅
arm64v8-previous-33.0.6-pkg-a3d7a288-dev-cb0f63fd34cb0788d734dbd6eca21beac27d4307-pr-535 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit aca6231 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-33.0.7-pkg-4136229d-dev-aca62316e3587e41a63d0b79c52ea631e465b79c-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-33.0.7-pkg-4136229d-dev-aca62316e3587e41a63d0b79c52ea631e465b79c-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-33.0.7-pkg-4136229d-dev-aca62316e3587e41a63d0b79c52ea631e465b79c-pr-535 ✅
arm64v8-previous-33.0.7-pkg-4136229d-dev-aca62316e3587e41a63d0b79c52ea631e465b79c-pr-535 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit a9a12a9 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-33.0.8-pkg-4fddadca-dev-a9a12a925e707b027e1d2fb1b1d7125f2f15908b-pr-535/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-33.0.8-pkg-4fddadca-dev-a9a12a925e707b027e1d2fb1b1d7125f2f15908b-pr-535/shellcheck-result.xml

Tag Passed
amd64-previous-33.0.8-pkg-4fddadca-dev-a9a12a925e707b027e1d2fb1b1d7125f2f15908b-pr-535 ✅
arm64v8-previous-33.0.8-pkg-4fddadca-dev-a9a12a925e707b027e1d2fb1b1d7125f2f15908b-pr-535 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Status: PRs Ready For Team Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /