Skip to content

Navigation Menu

Sign in
Sign up

Update default.conf.sample to deny dotfile access - #534

Open
nemchik wants to merge 3 commits into
develop from
deny-dotfile-access-develop
Open

Update default.conf.sample to deny dotfile access #534
nemchik wants to merge 3 commits into
develop from
deny-dotfile-access-develop

Conversation

@nemchik

@nemchik nemchik commented Feb 8, 2026

Copy link
Copy Markdown
Member

No description provided. 

Signed-off-by: Eric Nemchik <eric@nemchik.com>

Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-33.0.3rc1-pkg-99f0f2f3-dev-a7785a7b10193972755573c2a098249a18aaec08-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-33.0.3rc1-pkg-99f0f2f3-dev-a7785a7b10193972755573c2a098249a18aaec08-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-33.0.3rc1-pkg-99f0f2f3-dev-a7785a7b10193972755573c2a098249a18aaec08-pr-534 ❌
arm64v8-develop-33.0.3rc1-pkg-99f0f2f3-dev-a7785a7b10193972755573c2a098249a18aaec08-pr-534 ✅

Copilot AI review requested due to automatic review settings May 4, 2026 20:52
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bundled Nginx sample site config to block requests for dot-prefixed paths and documents the change in the generated README changelog.

Changes:

  • Broaden Nginx dotfile blocking rule in default.conf.sample.
  • Bump the sample config version header date.
  • Add a changelog entry in readme-vars.yml advising existing users to update their site config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
root/defaults/nginx/site-confs/default.conf.sample Expands the dotfile deny rule and updates the config version header.
readme-vars.yml Adds a changelog entry describing the dotfile-access change for existing users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +169 to +173
location ~ /\. {
deny all;
log_not_found off;
access_log off;
return 404;

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0beta2-pkg-b45b54b6-dev-33db4ee70529b5592680d7480a4a5d12cf28c3c9-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0beta2-pkg-b45b54b6-dev-33db4ee70529b5592680d7480a4a5d12cf28c3c9-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-34.0.0beta2-pkg-b45b54b6-dev-33db4ee70529b5592680d7480a4a5d12cf28c3c9-pr-534 ✅
arm64v8-develop-34.0.0beta2-pkg-b45b54b6-dev-33db4ee70529b5592680d7480a4a5d12cf28c3c9-pr-534 ✅

@LinuxServer-CI LinuxServer-CI moved this from PRs Ready For Team Review to PRs in Issue & PR Tracker May 4, 2026 
Signed-off-by: Eric Nemchik <eric@nemchik.com>

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0beta3-pkg-fa564346-dev-0fb391bbe237dffed3db219f713df690b0febec1-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0beta3-pkg-fa564346-dev-0fb391bbe237dffed3db219f713df690b0febec1-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-34.0.0beta3-pkg-fa564346-dev-0fb391bbe237dffed3db219f713df690b0febec1-pr-534 ✅
arm64v8-develop-34.0.0beta3-pkg-fa564346-dev-0fb391bbe237dffed3db219f713df690b0febec1-pr-534 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit 8a04c3a :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0beta4-pkg-d7f0e608-dev-8a04c3a7a2b1942b0e240ee6d70097457c7d99a8-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0beta4-pkg-d7f0e608-dev-8a04c3a7a2b1942b0e240ee6d70097457c7d99a8-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-34.0.0beta4-pkg-d7f0e608-dev-8a04c3a7a2b1942b0e240ee6d70097457c7d99a8-pr-534 ✅
arm64v8-develop-34.0.0beta4-pkg-d7f0e608-dev-8a04c3a7a2b1942b0e240ee6d70097457c7d99a8-pr-534 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit d474d1a :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0rc4-pkg-ba8db645-dev-d474d1a82435c20f96f67617a48915b3f7ec5e1a-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.0rc4-pkg-ba8db645-dev-d474d1a82435c20f96f67617a48915b3f7ec5e1a-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-34.0.0rc4-pkg-ba8db645-dev-d474d1a82435c20f96f67617a48915b3f7ec5e1a-pr-534 ✅
arm64v8-develop-34.0.0rc4-pkg-ba8db645-dev-d474d1a82435c20f96f67617a48915b3f7ec5e1a-pr-534 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit 67baf92 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.1rc2-pkg-80571caa-dev-67baf92edeb2d35696d9e94bf1a79627a536de7a-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.1rc2-pkg-80571caa-dev-67baf92edeb2d35696d9e94bf1a79627a536de7a-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-34.0.1rc2-pkg-80571caa-dev-67baf92edeb2d35696d9e94bf1a79627a536de7a-pr-534 ✅
arm64v8-develop-34.0.1rc2-pkg-80571caa-dev-67baf92edeb2d35696d9e94bf1a79627a536de7a-pr-534 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit 1734ce2 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.2rc1-pkg-6512f349-dev-1734ce2a06b332c9e889dc56ef5cf7dace970754-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-34.0.2rc1-pkg-6512f349-dev-1734ce2a06b332c9e889dc56ef5cf7dace970754-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-34.0.2rc1-pkg-6512f349-dev-1734ce2a06b332c9e889dc56ef5cf7dace970754-pr-534 ✅
arm64v8-develop-34.0.2rc1-pkg-6512f349-dev-1734ce2a06b332c9e889dc56ef5cf7dace970754-pr-534 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit bf187fe :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-35.0.0beta4-pkg-ac4dbea2-dev-bf187fe6276b1c302a2e6c12e0fd029f9117d149-pr-534/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-35.0.0beta4-pkg-ac4dbea2-dev-bf187fe6276b1c302a2e6c12e0fd029f9117d149-pr-534/shellcheck-result.xml

Tag Passed
amd64-develop-35.0.0beta4-pkg-ac4dbea2-dev-bf187fe6276b1c302a2e6c12e0fd029f9117d149-pr-534 ✅
arm64v8-develop-35.0.0beta4-pkg-ac4dbea2-dev-bf187fe6276b1c302a2e6c12e0fd029f9117d149-pr-534 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /