Skip to content

Navigation Menu

Sign in
Sign up

Update default.conf.sample to deny dotfile access - #533

Open
nemchik wants to merge 3 commits into
master from
deny-dotfile-access
Open

Update default.conf.sample to deny dotfile access #533
nemchik wants to merge 3 commits into
master from
deny-dotfile-access

Conversation

@nemchik

@nemchik nemchik commented Feb 8, 2026

Copy link
Copy Markdown
Member

No description provided. 

Signed-off-by: Eric Nemchik <eric@nemchik.com>

Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.2-pkg-9b48ead1-dev-33a2c06343da881b38531037af0dafd88a0104f2-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.2-pkg-9b48ead1-dev-33a2c06343da881b38531037af0dafd88a0104f2-pr-533/shellcheck-result.xml

Tag Passed
amd64-33.0.2-pkg-9b48ead1-dev-33a2c06343da881b38531037af0dafd88a0104f2-pr-533 ❌
arm64v8-33.0.2-pkg-9b48ead1-dev-33a2c06343da881b38531037af0dafd88a0104f2-pr-533 ✅ 

Removed duplicate configuration for the '.well-known' directory.
Copilot AI review requested due to automatic review settings May 4, 2026 20:50
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Nextcloud container’s default nginx sample config to harden access controls around dotfiles, and records the change in the generated README changelog for users who maintain their own copied nginx config.

Changes:

  • Replaced the old .ht*-specific nginx deny rule with a broader dotfile-matching location block.
  • Added logging suppression and an explicit 404 response for denied dotfile requests.
  • Added a changelog entry in readme-vars.yml telling existing users to update their nginx config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
root/defaults/nginx/site-confs/default.conf.sample Expands the nginx deny rule from .ht* files to dotfiles generally.
readme-vars.yml Adds the corresponding changelog note for existing users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread root/defaults/nginx/site-confs/default.conf.sample Outdated
@LinuxServer-CI LinuxServer-CI moved this from PRs Ready For Team Review to PRs in Issue & PR Tracker May 4, 2026

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.3-pkg-222677c1-dev-f149f49c20351cccab8399e813600d6b5ebc4b4c-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.3-pkg-222677c1-dev-f149f49c20351cccab8399e813600d6b5ebc4b4c-pr-533/shellcheck-result.xml

Tag Passed
amd64-33.0.3-pkg-222677c1-dev-f149f49c20351cccab8399e813600d6b5ebc4b4c-pr-533 ✅
arm64v8-33.0.3-pkg-222677c1-dev-f149f49c20351cccab8399e813600d6b5ebc4b4c-pr-533 ✅ 

Signed-off-by: Eric Nemchik <eric@nemchik.com>

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.3-pkg-f36a9e04-dev-501cd2613d95800f93de39029349e011ed044870-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.3-pkg-f36a9e04-dev-501cd2613d95800f93de39029349e011ed044870-pr-533/shellcheck-result.xml

Tag Passed
amd64-33.0.3-pkg-f36a9e04-dev-501cd2613d95800f93de39029349e011ed044870-pr-533 ✅
arm64v8-33.0.3-pkg-f36a9e04-dev-501cd2613d95800f93de39029349e011ed044870-pr-533 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit 6badf01 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.5-pkg-b7a66439-dev-6badf01bb82cb6c1ad5141a7edc2fe402d505b55-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.5-pkg-b7a66439-dev-6badf01bb82cb6c1ad5141a7edc2fe402d505b55-pr-533/shellcheck-result.xml

Tag Passed
amd64-33.0.5-pkg-b7a66439-dev-6badf01bb82cb6c1ad5141a7edc2fe402d505b55-pr-533 ✅
arm64v8-33.0.5-pkg-b7a66439-dev-6badf01bb82cb6c1ad5141a7edc2fe402d505b55-pr-533 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit 78bcc3e :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/34.0.1-pkg-f7046705-dev-78bcc3e8465f389ef004db7efb86149178d822ac-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/34.0.1-pkg-f7046705-dev-78bcc3e8465f389ef004db7efb86149178d822ac-pr-533/shellcheck-result.xml

Tag Passed
amd64-34.0.1-pkg-f7046705-dev-78bcc3e8465f389ef004db7efb86149178d822ac-pr-533 ✅
arm64v8-34.0.1-pkg-f7046705-dev-78bcc3e8465f389ef004db7efb86149178d822ac-pr-533 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit f94ba23 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/34.0.2-pkg-998da20b-dev-f94ba230df0b157f77a3903fb7cc19b2f725d868-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/34.0.2-pkg-998da20b-dev-f94ba230df0b157f77a3903fb7cc19b2f725d868-pr-533/shellcheck-result.xml

Tag Passed
amd64-34.0.2-pkg-998da20b-dev-f94ba230df0b157f77a3903fb7cc19b2f725d868-pr-533 ✅
arm64v8-34.0.2-pkg-998da20b-dev-f94ba230df0b157f77a3903fb7cc19b2f725d868-pr-533 ✅

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR for commit 672cd30 :
https://ci-tests.linuxserver.io/lspipepr/nextcloud/34.0.3-pkg-97326b95-dev-672cd30598a270f9fe3c6dd422316693eadc995b-pr-533/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/34.0.3-pkg-97326b95-dev-672cd30598a270f9fe3c6dd422316693eadc995b-pr-533/shellcheck-result.xml

Tag Passed
amd64-34.0.3-pkg-97326b95-dev-672cd30598a270f9fe3c6dd422316693eadc995b-pr-533 ✅
arm64v8-34.0.3-pkg-97326b95-dev-672cd30598a270f9fe3c6dd422316693eadc995b-pr-533 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /