Automated install script and maintenance - #523

I found an issue with the current script: it does not create the CAN_INSTALL file.
I don't know why it works at all in the current container script. However, the script creates the file now.

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Not stale, needs review.

@linuxserver Is there any chance to get this merged?

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

This still needs review and is not stale.

Thanks for the PR, but to be honest, I'm not in favor of it. It adds too much complexity for little gain.

You mentioned you got inspiration from the mariadb container but to be clear, the reasons we added those auto set up operations there are 1) mariadb doesn't have a setup wizard and 2) mariadb does support auto setup via script and/or conf file. Whereas Nextcloud already has a setup wizard that is pretty nice and intuitive.

This PR would significantly increase the maintenance and support burden for us for too little gain and thus has a high cost to benefit ratio.

PS. Even the mariadb container's setup vars are effective first time only. Changing the admin password later on does nothing, and that was intentional.

Thank you for reviewing the PR. 👍🏻

The changes only call some occ commands in order to reduce the maintenance burden on users / administrators.
At the moment you need to call the migration steps manually after upgrades (not possible via the web interface).

PS. Even the mariadb container's setup vars are effective first time only. Changing the admin password later on does nothing, and that was intentional.

Besides the password this is also the case in this PR. It just offers a convenient, declarative setup.

I understand if that's not your approach, but I don't see where it spawns additional significant maintenance burden.
It adds four new calls (2x necessary maintenance, setup, password) and some environment variables.

The rest is just moving around some things for a better program flow and documentation.

2. mariadb does support auto setup via script

So does NextCloud via occ. It's just a different interface for the same functionality.

https://www.linuxserver.io/blog/why-cant-you-just-implement-thing-i-want

I understand if that's not your approach, but I don't see where it spawns additional significant maintenance burden.

It's maintenance and support burden. Each new env var added (even if optional), means a bunch of users will try to set them, and incorrectly, needing support. Many of our users don't read. K.I.S.S. is a valuable principle for us.

@aptalca I see, this won't be merged then.

So I just opened #540 with the maintenance parts only - I hope this is less problematic, as it does not add env vars.