-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add transient_seat_v1 implementation #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deepin-ci-robot
commented
Aug 4, 2025
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zzxyb
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Reviewer's GuideAdds support for the Wayland transient_seat_v1 protocol by wiring up the transient seat manager in Helper, handling seat creation notifications to instantiate and manage WSeat objects, and responding with ready or deny to the compositor. Sequence diagram for transient_seat_v1 seat creation flowsequenceDiagram
participant TransientSeatManager as qw_transient_seat_manager_v1
participant Helper
participant TransientSeat as qw_transient_seat_v1
participant Seat as WSeat
participant NativeSeat as qw_seat
TransientSeatManager->>Helper: notify_create_seat(transientSeat)
Helper->>TransientSeat: qw_transient_seat_v1::from(transientSeat)
Helper->>Helper: Create WSeat(name)
Helper->>Seat: Check nativeHandle()
alt nativeHandle exists
Helper->>NativeSeat: connect destroyed -> safeDeleteLater
Helper->>TransientSeat: ready(seat->nativeHandle())
else nativeHandle missing
Helper->>TransientSeat: deny()
end
Class diagram for Helper and transient seat manager integrationclassDiagram
class Helper {
+void init()
-qw_transient_seat_manager_v1 *m_transientSeatManager
}
class qw_transient_seat_manager_v1 {
+signal notify_create_seat(wlr_transient_seat_v1*)
}
class qw_transient_seat_v1 {
+static from(wlr_transient_seat_v1*)
+ready(qw_seat*)
+deny()
}
class WSeat {
+WSeat(QString name)
+nativeHandle()
+safeDeleteLater()
+handle()
}
class qw_seat {
+signal destroyed
}
Helper --> qw_transient_seat_manager_v1 : uses
Helper --> WSeat : creates
Helper --> qw_transient_seat_v1 : uses
WSeat --> qw_seat : nativeHandle/handle
qw_seat --> Helper : destroyed signal
qw_transient_seat_manager_v1 --> Helper : notify_create_seat signal
qw_transient_seat_v1 --> Helper : ready/deny methods
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zzxyb - I've reviewed your changes - here's some feedback:
- You need to instantiate m_transientSeatManager (e.g. via qw_transient_seat_manager_v1::create) before connecting to its notify_create_seat signal.
- Consider using a more robust identifier generator (such as a UUID or atomic counter) instead of a static uint64_t to avoid potential overflow or collisions in seat names.
- Add logging in the deny branch to capture and diagnose why a transient seat request was refused at runtime.
Prompt for AI Agents
Please address the comments from this code review: ## Overall Comments - You need to instantiate m_transientSeatManager (e.g. via qw_transient_seat_manager_v1::create) before connecting to its notify_create_seat signal. - Consider using a more robust identifier generator (such as a UUID or atomic counter) instead of a static uint64_t to avoid potential overflow or collisions in seat names. - Add logging in the deny branch to capture and diagnose why a transient seat request was refused at runtime. ## Individual Comments ### Comment 1 <location> `src/seat/helper.cpp:1075` </location> <code_context> qw_alpha_modifier_v1::create(*m_server->handle()); + connect(m_transientSeatManager, &qw_transient_seat_manager_v1::notify_create_seat, this, [this](wlr_transient_seat_v1 *transientSeat) { + qw_transient_seat_v1 *qwTransientSeat = qw_transient_seat_v1::from(transientSeat); + static uint64_t i = 0; + QString name = QStringLiteral("transient-%1").arg(i++, 0, 10); + WSeat *seat = new WSeat(name); </code_context> <issue_to_address> Use of static variable for seat naming may cause issues in multi-instance scenarios. Using a static variable here can cause seat name collisions if multiple Helper instances exist. Use a member variable or a more reliable unique identifier instead. Suggested implementation: ```cpp QString name = QStringLiteral("transient-%1").arg(m_transientSeatCounter++, 0, 10); ``` 1. Add a member variable `uint64_t m_transientSeatCounter = 0;` to the class definition (likely in `helper.h`). 2. Initialize `m_transientSeatCounter` in the class constructor if not using in-class initialization. 3. Ensure all usages of the seat naming counter use this member variable. </issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
TAG Bot
New tag: 0.6.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #486
Create separate seats for virtual-pointer and virtual-keyboard Log:
TAG Bot
New tag: 0.7.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #540
TAG Bot
New tag: 0.7.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #560
TAG Bot
New tag: 0.7.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #562
TAG Bot
New tag: 0.7.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #569
TAG Bot
New tag: 0.7.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #611
TAG Bot
New tag: 0.7.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #619
TAG Bot
New tag: 0.7.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #625
TAG Bot
New tag: 0.8.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #676
TAG Bot
New tag: 0.8.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #691
TAG Bot
New tag: 0.8.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #718
TAG Bot
New tag: 0.8.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #733
Uh oh!
There was an error while loading. Please reload this page.
Create separate seats for virtual-pointer and virtual-keyboard
Log:
Summary by Sourcery
Add transient seat v1 support by including its manager, connecting creation signals, and spawning WSeat instances with proper lifecycle handling.
New Features: