-
-
Notifications
You must be signed in to change notification settings - Fork 423
fix(api): clean up bad JSON noise and fix progress bar going backwards#165
fix(api): clean up bad JSON noise and fix progress bar going backwards #165iammojogo-sudo wants to merge 18 commits into
Conversation
...tall and reload
Added links to Modly and Lightning Pixel on X for updates.
Change error message format for JSON decoding failure.
lightningpixel
commented
Jun 5, 2026
You’ll need to pull the dev branch and resolve the conflicts.
Then send me the PR, and it should be good
Added a sponsors section to acknowledge early supporters.
lightningpixel
commented
Jun 9, 2026
In your PR, there are changes to the README, package.json, and main.py files.
You’ll need to remove those changes, since they’re out of scope for this fix :)
iammojogo-sudo
commented
Jun 9, 2026
Ok sounds good! I think those were from an online dev change I was doing. Ill look at them and rid them asap :)
iammojogo-sudo
commented
Jun 9, 2026
I have two branches that Ive made so far. The progress-logging 'shouldn't' have anything in there related to the feature 1 changes, if thats what the updates are about? The branch transform-gizmo has those. Sorry I am confused. Its a newbie thing lol. So Im trying to commit the progress-logging branch. Those should ONLY have those in there that I changed. What do I do exactly because Im not sure what needs to be removed I apologize :(. I should probably stick to just making extensions because this is a lot for me to understand under my conditions. BUT I hope I can fix it because the transform gizmo is awesome :)
Updated README to reflect changes in CLI commands and community section.
@iammojogo-sudo
iammojogo-sudo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I fixed the changes needed.
Two small backend fixes.
First, when an extension's generator.py prints anything to stdout — debug
lines, tqdm bars, torch loading messages — it was showing up in the logs
as "[model] bad JSON: " on every single one. The lines weren't
malformed, they were just plain text that isn't part of the JSON protocol.
They now get forwarded to stderr as normal extension output instead.
Second, the progress bar could visibly snap backwards during generation.
The model loading phase slowly walks progress up to around 7%, but then
the extension starts its own generation and reports 0% first, resetting it.
Added a simple guard so progress can only move forward, never back.