-
Notifications
You must be signed in to change notification settings - Fork 2
docs: how lightdash solves sql fanouts #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
references/joins.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesshitchcock could you create charts in the demo website that we can link here? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. Will do that after lunch and add links after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR open to add required changes to SaaS demo models. Once reviewed I will build out the models in the demo site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I made a suggestion to fix a definition that I incorrectly provided in the bug ticket and I will add examples to the demo site this afternoon.
references/joins.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. Will do that after lunch and add links after that.
@jesshitchcock @ZeRego do we have the demo stuff so we can merge?
We should probably add them by logging into the demo site and creating real saved charts. I tried to link to a demo link a while ago and found it was broken after a few months.
@jesshitchcock @jpetey75 merging this PR without the demo examples. Opened a separate ticket just for that #16381
Co-authored-by: Jess Hitchcock <jesshitchcock@users.noreply.github.com>
26f57ac to
5eff875
Compare
Closes: #15582
Screenshot 2025年08月06日 at 17 07 34