Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Vips::Image#close. #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ioquatix wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from image-close
Open

Add Vips::Image#close. #340

ioquatix wants to merge 1 commit into master from image-close

Conversation

Copy link
Member

@ioquatix ioquatix commented Jun 24, 2022

I've been using this to help deal with memory usage issues.

dimroc reacted with thumbs up emoji
@ioquatix ioquatix requested a review from jcupitt June 24, 2022 07:01
Copy link
Contributor

Nakilon commented Jun 24, 2022

Hi. Just wondering. It is the thing that you've mentioned here? #67 (comment)
As I understand you said there it didn't help, only the GC.start did or something.

Copy link
Member Author

Wow that was a while ago.

Well, I have not run the benchmarks again. That being said, in theory a close method makes sense. In practice, more work might be needed to make it practical/useful.

Copy link
Member

jcupitt commented Jun 24, 2022

Hi, good idea, I've been meaning to add this.

Could we call it invalidate? That's the name we've used in the other libvips bindings.

close is rather close to post_close, the name we use for cleanup-on-finalize handlers.

Copy link

Doesn't this also need a Vips.attach_function :vips_image_invalidate_all, [:pointer], :void somewhere? Without it I get NoMethodError

ioquatix reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcupitt jcupitt Awaiting requested review from jcupitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /