Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move zend.max_allowed_stack_size=-1 check to signalConnect() #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Member

@kleisauke kleisauke commented Feb 21, 2025

Most users don't need to set this INI directive; it's only required when explicitly calling signalConnect() or using the SourceCustom and/or TargetCustom classes.

pizcadesaber, UgoTurner, micoli, Ciloe, Inkod, B-Galati, benconda, deluxetom, and mrtnmtth reacted with thumbs up emoji
Most users don't need to set this INI directive; it's only required
when explicitly calling `signalConnect()` or using the `SourceCustom`
and/or `TargetCustom` classes.
This was referenced Feb 21, 2025
Copy link

Thanks a lot for this PR, it's exactly what I was looking for, is there anything blocking the merge?

Copy link

Ciloe commented Apr 4, 2025

Hi ! When will you merge this PR ? Many thanks :)

Copy link
Member

jcupitt commented Apr 4, 2025

OK, let's do this! Thank you for the improvement, Kleis.

kleisauke, deluxetom, and UgoTurner reacted with rocket emoji

@jcupitt jcupitt merged commit 3b50384 into libvips:master Apr 4, 2025
6 checks passed
@kleisauke kleisauke deleted the move-stack-check-to-signalconnect branch April 4, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@deluxetom deluxetom deluxetom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /