-
Notifications
You must be signed in to change notification settings - Fork 168
Open
Conversation
wlbksy
commented
Jul 25, 2017
it works
Thanks for the efforts.
Compiling with gcc (GCC) 4.8.5 and installing under Python 3.6.2 :: Continuum Analytics, Inc. I get the following error on import:
ImportError: dynamic module does not define module export function (PyInit_LargeVis)
The solution to this seems to be renaming the function PyInit_myextension(void) in LargeVismodule.cpp:171 to PyInit_LargeVis(void), alongside with the matching change in line 158, where it also still says myextension.
@lmcinnes can you validate this and update your pull request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python module is compatible only with Python2. I have made the minor necessary changes to simultaneously support both Python3 and Python2.