Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add files field in package.json #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poppinlp wants to merge 4 commits into leetcode-tools:master
base: master
Choose a base branch
Loading
from poppinlp:files_field
Open

Add files field in package.json #8

poppinlp wants to merge 4 commits into leetcode-tools:master from poppinlp:files_field

Conversation

Copy link

@poppinlp poppinlp commented Apr 15, 2019

As we mentioned here. And some handy things.

  • Use files field to specify included files.
  • Remove preferGlobal since it's deprecated.
  • Add more node version in .travis.yml.
  • Fix some lint errors in lib/plugins/cache.js.
  • Update .gitignore from gitignore repo.

Copy link
Author

BTW. Looks like some test cases for plugins are broken in master branch. But I haven't look into it yet.
image

Copy link

jdneo commented Apr 21, 2019

Thank you @poppinlp

One nit is that there is no need to test Node.js on 4, 6 (the extension requires 8 at least)

Copy link
Author

@jdneo OK. I'll fix it tonight. Sorry for my late reply. I'm in Vietnam recently.

@jdneo jdneo requested a review from Vigilans April 24, 2019 11:23
Copy link

@jasonchaw jasonchaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vigilans Vigilans Awaiting requested review from Vigilans

1 more reviewer

@jasonchaw jasonchaw jasonchaw approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /