-
Notifications
You must be signed in to change notification settings - Fork 50
add leetcode user -c that user can login with cookie #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry I did not get the point of travis-ci error
jdneo
commented
Nov 29, 2019
Thank you @yihong0618.
I'll take a look for this change recently. Probably on Sunday or next Monday.
wanquanw
commented
Dec 1, 2019
It seems like that the travis-ci errors are about code style problems.
@jdneo
jdneo
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Align the indention?
jdneo
commented
Dec 2, 2019
Thanks @yihong0618,
Do you need me to publish it now? I have no Windows machine on my side for now, so I cannot check my the CI job fails.
It would be great if you can help verify it. 😄
Yes, please. And it seems that I can't find anything useful for the ci message. Sorry I did not find my error.
And I think in the vscode-leetcode side only need to add leetcode.cookieIn(maybe like leetcode.signIn just change password to cookie) is OK. But I think its a bad idea for solve the problem. LOL~
jdneo
commented
Dec 2, 2019
@yihong0618 Hmm, can we open a webview to automatically get the cookie? The webview in VS Code could not achieve that because the VS Code team does not provide APIs to do that. I'm not sure if there is a easy-to-go solution in Node.js.
jdneo
commented
Dec 2, 2019
2.6.17 released
jdneo
commented
Dec 3, 2019
Oh, that's a great article. thanks for sharing.
Yes I agree that if we need 100M more size to bypass it, there is no need to do that.
Add a method that user can login with cookie relate to vscode-leetcode can't login problem