Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: adjust timestep calculations for DDIM and TCD #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wbruna wants to merge 1 commit into leejet:master
base: master
Choose a base branch
Loading
from wbruna:fix_ddim_tcd_timesteps

Conversation

Copy link
Contributor

@wbruna wbruna commented Apr 24, 2025

On img2img, the number of steps correspond to the last precalculated sigma values, but the internal alphas_cumprod and compvis_sigmas were being computed over the entire step range.

Also, tweaks the prev_timestep calculation on DDIM to better match the current timestamp (like on TCD), to avoid inconsistencies due to rounding.

This partially fixes #663 , and seems enough to at least generate coherent images. But low strength generations still produce noisy outputs.

vmobilis reacted with thumbs up emoji Green-Sky reacted with eyes emoji
On img2img, the number of steps correspond to the last precalculated sigma
values, but the internal alphas_cumprod and compvis_sigmas were being computed
over the entire step range.
Also, tweaks the prev_timestep calculation on DDIM to better match the current
timestamp (like on TCD), to avoid inconsistencies due to rounding.
@wbruna wbruna force-pushed the fix_ddim_tcd_timesteps branch from 7aa4d93 to 2e0c46a Compare July 26, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

img2img not working with DDIM trailing or TCD
1 participant

AltStyle によって変換されたページ (->オリジナル) /