Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GGMLRunner: avoid multiple calls to get_graph #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idostyle wants to merge 1 commit into leejet:master
base: master
Choose a base branch
Loading
from idostyle:get_graph

Conversation

Copy link
Contributor

@idostyle idostyle commented Apr 3, 2025

Not setting up the compute graph twice might result in a minor (/negligible?) performance improvement.

Previously it worked like the following in GGMLRunner#compute:

  1. calls alloc_compute_buffer
    1.1 calls reset_compute_ctx
    1.2 calls get_graph
  2. calls reset_compute_ctx
  3. calls get_graph

Tested on cpu and vulkan locally.

stduhpf and vmobilis reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /