👋 Thanks for contributing!

We will assign a reviewer within the next two weeks. In the meantime, please ensure that:

• You ran pre-commit locally
• All issue requirements are satisfied
• The contribution is aligned with our Contributing guidelines. Pay extra attention to Using generative AI. Pull requests that don't follow the guidelines will be closed.

We'll be in touch! 😊

hi @MisRob, On small screens, the Edit channel option goes into the three-dots menu. The original code showed a red error icon when the channel has no language set. Since KDropdownMenu only accepts strings for option labels, I am thinking to use an emoji instead:

let label = this.$tr('editChannel');
if (!this.currentChannel.language) {
 label = `${label} ⚠️`;
}

Is this okay, or would you prefer something like "Edit channel (incomplete)"?

one more thing I wanted to ask about original code had some duplication where users could access the same thing from both the Share dropdown and three-dots menu:

• "Share token" / "Get token" → both open token modal
• "Invite collaborators" / "Share channel" → both go to share page
  I kept this for backward compatibility. Should I remove the duplicates from the three-dots menu?

Hi @vtushar06,

On small screens, the Edit channel option goes into the three-dots menu. The original code showed a red error icon when the channel has no language set. Since KDropdownMenu only accepts strings for option labels, I am thinking to use an emoji instead

Emoji sounds creative ;)!

KDropdownMenu can show icons (doc) but yes - not colored ones. Would you please post before/after screenshot of that place with the icon (as supported by KDropdownMenu now)? Then we can see.

one more thing I wanted to ask about original code had some duplication where users could access the same thing from both the Share dropdown and three-dots menu...

Yes, as you mentioned, let's keep the options exactly the same now. I am not sure what was the original decision, it may be intentional - and not exactly in scope of this project.

Before we assign a maintainer, I will first try inviting the community review ;)

📢 ✨ Community Review guidance for both authors and reviewers.

Hii @MisRob! Thank you,
I've tested both approaches you suggested:

1. Emoji Approach:
   Screenshot showing "Edit channel details ⚠️" and warning appears after the text and more noticeable due to colored emoji..
   ...

...

2. Icon Approach (using KDropdownMenu's icon prop):
   Screenshot showing "⚠ Edit channel details" and KDropdownMenu places icons before the label text
   ...

I suggest keeping the emoji approach because the warning appears after the text, which is more natural for an indicator
Please let me know which approach you prefer, and I'll finalize the implementation accordingly.

Hey @vtushar06 ! I am still learning testing , I see the tests now check the computed properties directly
instead of the DOM. Should we also test that handleShareMenuSelect and handleChannelMenuSelect actually get called with the right values when users click? Or is testing the computed properties sufficient?

hey @abhiraj75, In our codebase, we're still migrating from old test patterns. The TreeViewBase tests use wrapper.vm computed properties, which is what was approved as not in this PR scope. But best practice going forward is to test user-observable behavior (what appears on screen) rather than internal handler calls.

Thanks @vtushar06 !

Hi @vtushar06

I've tested both approaches you suggested:

Thanks for following-up, appreciated! And meanwhile similar issues showed up in other places. I'm now coordinating a decision on how to proceed. Will let you know soon.

@vtushar06 we will update KDS to allow for easier dropdown item customization. Tracking here learningequality/kolibri-design-system#1200. As soon as it's done I will install the new KDS version in Studio, and then you can use it :) In any case, thanks for raising that and also thinking through options. I prefer KDS update because it will be useful in more places and in general, and will allow us to use KDS icons as usual.

sure @MisRob, please let me know If I can help there too, I would like to work on that issue in KDS..