-
Notifications
You must be signed in to change notification settings - Fork 286
Comments
UI Modal for Flagging ContentNodes#4375
UI Modal for Flagging ContentNodes #4375vkWeb wants to merge 1 commit intolearningequality:unstable from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of embedding the modal in each content node list item, having the component emit an event to a common place in the UI, makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember why I did this way 🤔
@ozer550 will you be willing to refactor this and take this forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good :D
Btw upon trying to remember, my mind trace says that --
Most probably I did this because Vue allows emmiting events from a parent to a direct child only. So I had to catch the event on contentnode list item, I was not able to catch the event anywhere else.
The workaround for this was to utilise an event bus. So to keep things simple I might have done this.
Summary
This PR --
Flag contentoption to the contentnode three-dot menu.Flag contentoption that shows checkboxes for reporting a node.TO DO --
handleSubmit()method. Can only be done after Implement feedback object hierarchy #4373 is merged.Manual verification steps performed
Manual verification mainly revolves around checking when and when not
Flag contentoption is shown. So let's divide it into two parts -- first for normal users and second for admins.For normal non-admin users
Flag option should show only when these three conditions meet -- AI feature flag is enabled for user, node is not of topic kind and user does not have edit permissions on the channel, that is, all public channels that user have not created themselves.
So to test the above conditions follow the below steps --
Flag contentoption should not be there.Flag contentoption should be there.For admin users
Flag option should show in ALL channels when -- AI feature flag is enabled for admin and node is not of topic kind.
So to test the above conditions follow the below steps --
Flag contentoption should not be there.Flag contentoption should be there.Screenshots (if applicable)
1.
Flag contentoption UIimage
2. Flag modal UI
image
Reviewer guidance
Performing manual verification steps should make us confident about the changes.
References
Closes #4367.
Closes #4365.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)