-
Notifications
You must be signed in to change notification settings - Fork 6
feat: remove SignUpByEmail #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank 沉寂 for bringing this to our attention.
leancloud/users.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果不指定 username,云端会报错
{"code":200,"error":"Username is missing or empty."}不过其实我不是很确定 SignUpByEmail 这个接口当时引入的动机,其他 SDK 都没有凭邮箱注册的接口(只有凭邮箱登录的接口)。
可能这个留给应用层面决定更好,因为如果应用提供凭邮箱注册的功能,它可能设计成需要另外填用户名,也可能设计成用户名和邮箱一样,也可能设计成用户名随机生成。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我也没有印象,如果其他 SDK 都没有是不是应该去掉 ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉了(反正之前有 bug 也不能用,去掉也不破坏兼容性)
to be consistent with other SDKs. This method did not work before so the removal does not introduce a breaking change.
Thank 沉寂 for bringing this to our attention.