reimplemented litmoon#217

Open

nonchip wants to merge 2 commits intoleafo:master from

nonchip:litmoon

Open

reimplemented litmoon #217
nonchip wants to merge 2 commits intoleafo:master from
nonchip:litmoon

Conversation

@nonchip

Copy link

Contributor

@nonchip nonchip commented Sep 28, 2015

there you go. using lpeg this time, because what the hell did I hack there before :P

tried to break as little as possible, and went with a factory approach where I always default to litmoon=false and generate the default functions in case someone was depending on them somewhere else.

general idea:

--declaration:
- some_func=(...) -> blah
+ some_func_factory(litmoon=false) -> (...) -> blah
+ some_func = some_func_factory!
--call:
- some_func ... -- this would still work elsewhere
+ some_func(litmoon) ...

also the mechanism for filtering is actually pretty simple: extend moonscript.parser.literals.EmptyLine on demand (using above factory design) and redefine Line as (CheckIndent * Statement + Space * #Stop) + EmptyLine

@nonchip


 implemented litmoon

fb977a9

@nonchip

Copy link

Contributor Author

nonchip commented Sep 28, 2015

whoops, thanks travis, missed something there, i'll fix

@nonchip


 messed up priorities

32bff9a

@nonchip

Copy link

Contributor Author

nonchip commented Sep 28, 2015

done. Line must have EmptyLine at the end, not at the start.

@nonchip nonchip changed the title ~~(削除) implemented litmoon (削除ここまで)~~ (追記) reimplemented litmoon (追記ここまで)

Sep 28, 2015

@nonchip

Copy link

Contributor Author

nonchip commented Oct 6, 2015

@leafo ping?

@leafo

Copy link

Owner

leafo commented Oct 6, 2015

Haven't had a chance to review yet, this is a much bigger change.

@nonchip

Copy link

Contributor Author

nonchip commented Nov 24, 2015

will this be reviewed anytime soon? most of the changes are autocompiled lua anyway, busted passes (ofc i added a test for litmoon), and there's at least 2 projects already using it, so imho it'd be worth the time...

@nonchip

Copy link

Contributor Author

nonchip commented Mar 9, 2016

seriously, i don't see how this "bigger change" (consisting of some few adjustments in about 5 files and running make) can stall for half a year, given the fact you tweeted me about "looking into it real soon" last year...

[画像:leafo]

leafo reviewed

Apr 8, 2016

View reviewed changes

moonscript/base.moon

concat moonpaths, ";"

to_lua = (text, options={}) ->

to_lua = (text, options={}, litmoon=false) ->

Copy link

Owner

@leafo leafo Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding another argument specific to litmoon is a good change to this interface. (If we add more formats are we supposed to keep adding new arguments?) Any reason you didn't re-purpose options?

@nonchip

Copy link

Contributor Author

nonchip commented Apr 14, 2016

you're right, i'll try to reimplement this using the options tables instead.

did kinda mistake them for being strictly structured stuff i'd better not touch...

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reimplemented litmoon#217

reimplemented litmoon #217
nonchip wants to merge 2 commits intoleafo:master from
nonchip:litmoon

Conversation

@nonchip nonchip commented Sep 28, 2015

Uh oh!

nonchip commented Sep 28, 2015

Uh oh!

nonchip commented Sep 28, 2015

Uh oh!

nonchip commented Oct 6, 2015

Uh oh!

leafo commented Oct 6, 2015

Uh oh!

nonchip commented Nov 24, 2015

Uh oh!

nonchip commented Mar 9, 2016

Uh oh!

@leafo leafo Apr 8, 2016

Choose a reason for hiding this comment

Uh oh!

nonchip commented Apr 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants