-
Notifications
You must be signed in to change notification settings - Fork 514
Fix Issue 673: Parse error with named CSS grid lines and areas#643
Open
blizzardengle wants to merge 3 commits into
Open
Fix Issue 673: Parse error with named CSS grid lines and areas #643blizzardengle wants to merge 3 commits into
blizzardengle wants to merge 3 commits into
Conversation
This adds a patch to lessc->compile that adds a protection to CSS named grids. Once all other parsing is done successfully the protection is removed and the compiled CSS returned. The protection is a rough patch that removes brackets and replaces them with 3 underscores so [grid-name] becomes ___grid-name___ which does not trigger any parser errors allowing everything to be parsed as normal. If this patch is added into lessphp permanently I would suggest doing 4 underscores for (paranoia) safeties sake or a different pattern that is still safe to parse but less common to be used in someones code.
This is an additional patch to allow lessphp to compile CSS named grids from imported files.
This patch protects CSS named grids by replacing the brackets before any parsing or compiling happens. Once all parsing and compiling is done the brackets are replaced. NOTE: Brackets are changed to 3 underscores which works great but has a small chance of clashing with someones code, in this case I would suggest changing it to 4 underscores. Who is writing that many in their less/ css?
@blizzardengle
blizzardengle
changed the title
(削除) Issue 673 (削除ここまで)
(追記) Fix Issue 673: Parse error with named CSS grid lines and areas (追記ここまで)
Nov 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch protects CSS named grids by replacing the brackets before any parsing or compiling happens. Once all parsing and compiling is done the brackets are replaced.
NOTE
Brackets are changed to 3 underscores [grid-name] => ___grid-name___ which works great but has a small chance of clashing with someones code, in this case I would suggest changing it to 4 underscores. Who is writing that many in their less/ css?