-
Notifications
You must be signed in to change notification settings - Fork 514
Open
Conversation
thybzi
commented
Dec 7, 2013
Author
This thing about caching is what we are using intensively in a project with lot of LESS styles compiled with lessphp.
Please accept this request, or explain problems/issues it can cause (though I can't imagine any - because it is a new feature, changing nothing in existing functional :)
I suppose this feature could be useful for everyone who uses lessphp.
thybzi
commented
Dec 14, 2013
Author
Please merge this pull request, I think this feature will be useful for everyone using plessc CLI tool. Also, it shouldn't break anything currently working.
thybzi
commented
Dec 22, 2013
Author
Would you please (review and) merge that?
thybzi
commented
Jan 18, 2014
Author
Why don't accept this cool pull request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented caching feature (that exists in main module) to
plessccommand-line tool.Added
-qkey toplesscin order to enable this new feature.The code if based on this example from
lessphpdocumentation:http://leafo.net/lessphp/docs/#compiling_automatically
Generates
.lessphpfiles beside corresponded less-files compiled, and then tries to read them and use as cache.Rewrites cache files when needed (
$cache_new["updated"] > $cache["updated"]).