-
Notifications
You must be signed in to change notification settings - Fork 165
fix: rename red palette to magenta and add true red palette #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename red palette to magenta and add true red palette #1189
Conversation
@Rajesh-Nagarajan-11 @leecalcote @nebula-aac , I request a review.
@saurabhraghuvanshii ,
I've updated the magenta palette to proper magenta (purple-pink) shades:
magenta[70]: #FFF0FA(was #FFF0F0)magenta[60]: #FFB3E6(was #FFB3B9)magenta[50]: #FF66CC(was #FF6179)magenta[40]: #E600AC(was #ff385c)magenta[30]: #B30086(was #B3153D)magenta[20]: #800060(was #8C0a2F)magenta[10]: #4D0039(was #660624)
The magenta palette now uses true purple-pink colors instead of rose-red. The red palette remains unchanged with true red colors based on #F91313.
saurabhraghuvanshii
commented
Dec 14, 2025
@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup
jeetburman
commented
Dec 15, 2025
@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup
I understand. Thank you for clarifying. I will make the necessary changes..
saurabhraghuvanshii
commented
Dec 15, 2025
@jeetburman I would suggest leave this issue solve other open issue. Because minor change can break many websites
saurabhraghuvanshii
commented
Dec 15, 2025
If you still trying to solve you have to go with all meshery and layer5 repo to verify your changes
kishore08-07
commented
Dec 15, 2025
@jeetburman
Thank you for your contribution!
Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT
Add it as an agenda item to the meeting minutes, if you would :)
jeetburman
commented
Dec 15, 2025
@jeetburman Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would :)
I have added my discussion topic in the agenda items...
nebula-aac
commented
Dec 18, 2025
ack, reviewing now
937e6b8 to
6600081
Compare
jeetburman
commented
Dec 19, 2025
I have freshly made the changes this time. I preserved the original red pallette and add two new pallettes... Magenta and Crimson. @saurabhraghuvanshii @nebula-aac , let me know if any further change is required.
- Add true magenta palette (purple-pink) with base color #E600AC - Add crimson palette (pure red) with base color #F91313 - Preserve existing red palette for backward compatibility - Export both new palettes in colors index Closes layer5io#602 Signed-off-by: Jeet Burman <jeetburrman@gmail.com>
1ac2491 to
6d7a97c
Compare
saurabhraghuvanshii
commented
Dec 19, 2025
@jeetburman lgtm!!
This PR addresses issue #602 by renaming the existing red palette to magenta and introducing a new true red palette.
Resolves #602
Notes for Reviewers
This PR fixes #602
The existing
redpalette contained pinkish-magenta hues (e.g.,#ff385c,#FFB3B9). This has been renamed tomagentafor semantic accuracy. A newredpalette has been created using#F91313as the base color, which is already used for notification errors and provides true red colors.Changes are backward compatible - the magenta palette retains all the previous red values, and components using error states now benefit from more accurate red colors.
Signed commits