[newcomers-form] fix: accept Google Drive links in profile picture validation #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

hudazaan wants to merge 7 commits into layer5io:master

from hudazaan:fix/profile-picture-validation

Open

[newcomers-form] fix: accept Google Drive links in profile picture validation #7041

hudazaan wants to merge 7 commits into layer5io:master from hudazaan:fix/profile-picture-validation

Conversation

@hudazaan

Copy link

@hudazaan hudazaan commented Oct 16, 2025

Description

This PR fixes #6986

Fixed the profile picture validation to accept Google Drive links. Previously, when users tried to paste Google Drive links as profile pictures, the form showed the error "URL must point to an image file (jpg, jpeg, png, svg, webp or gif)".

Notes for Reviewers

This follows the expected behavior of accepting Google Drive links that point to image files
No breaking changes to existing functionality
Maintains file extension validation for non-Google Drive URLs

Signed commits

Yes, I signed my commits.

hudazaan added 2 commits

October 16, 2025 22:49

@hudazaan


 fix: accept Google Drive links in profile picture validation

d6d3ef2

@hudazaan


 fix: accept Google Drive links in profile picture validation

0bc92e9

@l5io

Copy link

Contributor

l5io commented Oct 16, 2025

🚀 Preview for commit 0bc92e9 at: https://68f13121a6457b84033b3eb4--layer5.netlify.app

Fireentity

Fireentity suggested changes

Oct 16, 2025

View reviewed changes

Copy link

Contributor

@Fireentity Fireentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this contribution! The logic is looking good.

We can simplify the validation by using a single regular expression. This makes the intent clearer and is easier to maintain than multiple includes() checks.

const validGoogleDrivePattern = /drive\.google\.com\/file\/d\/.+\/(view|uc\?)/;
if (value.includes('drive.google.com') && !validGoogleDrivePattern.test(value)) {
 error = "Please provide a direct Google Drive file link.";
} else {
 // ...
}

I also noticed the DCO check is failing. This happens when commits are not signed off. https://docs.meshery.io/project/contributing

@FreemanBoss

Copy link

Contributor

FreemanBoss commented Oct 17, 2025

This is a very important to work on as I faced this issue through while filling the form. Between, the DCO checks is failing.

@hudazaan

Copy link

Author

hudazaan commented Oct 17, 2025

Thankyou for the feedback. I'll simplify the validation and also fix the DCO check issue.

@Namanv0509


 Merge branch 'master' into fix/profile-picture-validation

a4dcc18

@Namanv0509

Copy link

Contributor

Namanv0509 commented Oct 18, 2025

@hudazaan thanks for your contribution , you can check https://github.com/layer5io/layer5/pull/7041/checks?check_run_id=53083532468 to fix the DCO error

@l5io

Copy link

Contributor

l5io commented Oct 18, 2025

🚀 Preview for commit a4dcc18 at: https://68f3b03153e83cd59ef816d1--layer5.netlify.app

@Rajesh-Nagarajan-11

Copy link

Member

Rajesh-Nagarajan-11 commented Oct 24, 2025

DCO Failed ⚠️ and @Fireentity Thanks for the review

@Rajesh-Nagarajan-11

Copy link

Member

Rajesh-Nagarajan-11 commented Oct 27, 2025

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT
Add it as an agenda item to the meeting minutes, if you would 😄

@Rajesh-Nagarajan-11

Copy link

Member

Rajesh-Nagarajan-11 commented Nov 2, 2025

Thank you for your contribution!
Let’s discuss this during the website call tomorrow (November 3) at 5:30 PM IST | 7:00 AM CT.
Please add it as an agenda item to the meeting minutes
😊

@Rajesh-Nagarajan-11


 Merge branch 'master' into fix/profile-picture-validation

6a3ff67

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 requested a review from Fireentity

November 9, 2025 15:08

@l5io

Copy link

Contributor

l5io commented Nov 9, 2025

🚀 Preview for commit 6a3ff67 at: https://6910b1998306858f758ebaee--layer5.netlify.app

@leecalcote


 Merge branch 'master' into fix/profile-picture-validation

61cd707

@leecalcote

Copy link

Member

leecalcote commented Dec 1, 2025

@hudazaan, you will need to add your sign off on your commit.

@kishore08-07

Copy link

Contributor

kishore08-07 commented Dec 1, 2025

@hudazaan
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~3 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin fix/profile-picture-validation

@l5io

Copy link

Contributor

l5io commented Dec 1, 2025

🚀 Preview for commit 61cd707 at: https://692d3f50fe3a2e97233a6df2--layer5.netlify.app

@Rajesh-Nagarajan-11


 Merge branch 'master' into fix/profile-picture-validation

aba1488

@l5io

Copy link

Contributor

l5io commented Dec 1, 2025

🚀 Preview for commit aba1488 at: https://692d46de73dabd993bafbeba--layer5.netlify.app

@Rajesh-Nagarajan-11


 Merge branch 'master' into fix/profile-picture-validation

c25cc46

@l5io

Copy link

Contributor

l5io commented Dec 1, 2025

🚀 Preview for commit c25cc46 at: https://692d8639d8a8d80213e2035c--layer5.netlify.app

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 requested a review from Copilot

December 1, 2025 12:33

Copilot AI reviewed

Dec 1, 2025

View reviewed changes

Copy link

Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes validation logic for profile picture URLs to accept Google Drive links in addition to direct image file URLs. Previously, users could not use Google Drive links as profile pictures due to the extension-based validation that rejected URLs without standard image file extensions.

Key Changes:

Added special handling for Google Drive URLs in the picture validation function
Implemented validation to ensure Google Drive links are properly formatted file links
Updated the user-facing help text to clarify acceptable Google Drive link formats

src/sections/Community/Web-based-from/index.js

const isViewLink = value.includes("/view");

const isDownloadLink = value.includes("/uc?");

if (!isFileLink || (!isViewLink && !isDownloadLink)) {

Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation logic is incorrect. It requires BOTH /file/d/ AND either /view OR /uc? to be present, but Google Drive file links typically have the format drive.google.com/file/d/{ID}/view where /view and /uc? don't appear together. The condition !isFileLink || (!isViewLink && !isDownloadLink) will reject valid links like drive.google.com/file/d/abc123/view. Change to if (!isFileLink || !(isViewLink || isDownloadLink)).

Suggested change

if (!isFileLink || (!isViewLink &&!isDownloadLink)) {

if (!isFileLink || !(isViewLink ||isDownloadLink)) {

Copilot uses AI. Check for mistakes.

src/sections/Community/Web-based-from/index.js

{errors.picture && touched.picture && <div style={{ margin: "0px", color: "red", fontSize: "16px" }}>{errors.picture}</div>}

<p className="para label">Please provide a link to your profile photo. Profile photos are used for <Link to="/community/members">community member profiles</Link> of longstanding community members. For Google Drive links, please ensure you're using direct image links that end with .jpg, .png, etc.</p>

Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidance text contradicts the code logic. It states Google Drive links should 'end with .jpg, .png, etc.', but the validation code accepts Google Drive links without checking file extensions. This misleading instruction may confuse users. Either remove the extension requirement from the text or update the code to validate Google Drive link extensions.

Suggested change

<p className="para label">Please provide a link to your profile photo. Profile photos are used for <Link to="/community/members">community member profiles</Link> of longstanding community members. For Google Drive links, please ensure you're using a direct image link that is accessible to anyone with the link.</p>

Copilot uses AI. Check for mistakes.

@Fireentity

Copy link

Contributor

Fireentity commented Dec 7, 2025

@hudazaan Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would 🙂

@kishore08-07

Copy link

Contributor

kishore08-07 commented Dec 24, 2025 •

edited

Loading

@hudazaan
Lack of response will lead to this PR being closed.

@hudazaan

Copy link

Author

hudazaan commented Dec 24, 2025

@hudazaan Lack of response will lead to this PR being closed.

Apologies for the long delay. I'll update this PR today and will be consistent going forward.

@hudazaan

Copy link

Author

hudazaan commented Dec 24, 2025

@kishore08-07 I need your help. I squashed my signed commits but facing some tracking references issues now and git push --force-with-lease is failing. what should I do in such case? If you can clear my confusion, I'll update the work accordingly.

Labels

None yet

8 participants

@hudazaan @l5io @FreemanBoss @Namanv0509 @Rajesh-Nagarajan-11 @leecalcote @kishore08-07 @Fireentity

[newcomers-form] fix: accept Google Drive links in profile picture validation #7041

Are you sure you want to change the base?

[newcomers-form] fix: accept Google Drive links in profile picture validation #7041

Uh oh!

Conversation

@hudazaan hudazaan commented Oct 16, 2025

Uh oh!

l5io commented Oct 16, 2025

Uh oh!

@Fireentity Fireentity left a comment

Choose a reason for hiding this comment

Uh oh!

FreemanBoss commented Oct 17, 2025

Uh oh!

hudazaan commented Oct 17, 2025

Uh oh!

Namanv0509 commented Oct 18, 2025

Uh oh!

l5io commented Oct 18, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Oct 24, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Oct 27, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Nov 2, 2025

Uh oh!

l5io commented Nov 9, 2025

Uh oh!

leecalcote commented Dec 1, 2025

Uh oh!

kishore08-07 commented Dec 1, 2025

Uh oh!

l5io commented Dec 1, 2025

Uh oh!

l5io commented Dec 1, 2025

Uh oh!

l5io commented Dec 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Fireentity commented Dec 7, 2025

Uh oh!

kishore08-07 commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hudazaan commented Dec 24, 2025

Uh oh!

hudazaan commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kishore08-07 commented Dec 24, 2025 •

edited

Loading