-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Conversation
@lava can we get this one merged?
Adding $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}> also fixes the use case for including matplotlib-cpp in cmake with FetchContent:
include(FetchContent) FetchContent_Declare(matplotlibcpp GIT_REPOSITORY https://github.com/lava/matplotlib-cpp.git GIT_TAG ef0383f1315d32e0156335e10b82e90b334f6d9f ) FetchContent_MakeAvailable(matplotlibcpp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two things:
matplotib_cpptarget requires$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>to be used withadd_subdirectoryso thatmatplotlibcpp.hcan be included seamlesslyexamplessubdirectory, therefore the$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/examples>is useless