Fix compiling errors on Windows#271

Closed

kokosxD wants to merge 3 commits into

lava:master from

kokosxD:master

Closed

Fix compiling errors on Windows #271
kokosxD wants to merge 3 commits into
lava:master from
kokosxD:master

Conversation

@kokosxD

@kokosxD kokosxD commented May 21, 2021

Copy link

Copy Markdown

Compiling code from some examples results in compiling errors on 64-bit Windows using Visual Studio 2019.
This request fixes these errors and improves the Windows experience of matplotlib-cpp.

Note that compiling in DEBUG configuration still causes some runtime exceptions, but this is just a comment and this request doesn't deal with fixing it

Traceback (most recent call last):
 File "Python39\site-packages\numpy\core\__init__.py", line 22, in <module>
 from . import multiarray
 File "Python39\site-packages\numpy\core\multiarray.py", line 12, in <module>
 from . import overrides
 File "Python39\site-packages\numpy\core\overrides.py", line 7, in <module>
 from numpy.core._multiarray_umath import (
ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
 File "Python39\site-packages\numpy\__init__.py", line 145, in <module>
 from . import core
 File "Python39\site-packages\numpy\core\__init__.py", line 48, in <module>
 raise ImportError(msg)
ImportError:
IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!
Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.
We have compiled some common reasons and troubleshooting tips at:
 https://numpy.org/devdocs/user/troubleshooting-importerror.html
Please note and check the following:
 * The Python version is: Python3.9 from "build.exe"
 * The NumPy version is: "1.20.3"
and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.
Original error was: No module named 'numpy.core._multiarray_umath'
Traceback (most recent call last):
 File "Python39\site-packages\numpy\core\__init__.py", line 22, in <module>
 from . import multiarray
 File "Python39\site-packages\numpy\core\multiarray.py", line 12, in <module>
 from . import overrides
 File "Python39\site-packages\numpy\core\overrides.py", line 7, in <module>
 from numpy.core._multiarray_umath import (
ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
 File "Python39\lib\site-packages\matplotlib\__init__.py", line 107, in <module>
 from . import _api, cbook, docstring, rcsetup
 File "Python39\lib\site-packages\matplotlib\cbook\__init__.py", line 28, in <module>
 import numpy as np
 File "Python39\site-packages\numpy\__init__.py", line 145, in <module>
 from . import core
 File "Python39\site-packages\numpy\core\__init__.py", line 48, in <module>
 raise ImportError(msg)
ImportError:
IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!
Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.
We have compiled some common reasons and troubleshooting tips at:
 https://numpy.org/devdocs/user/troubleshooting-importerror.html
Please note and check the following:
 * The Python version is: Python3.9 from "build.exe"
 * The NumPy version is: "1.20.3"
and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.
Original error was: No module named 'numpy.core._multiarray_umath'

kokosxD added 3 commits

May 21, 2021 18:34


 Fix explicit specialization has already been defined

efa69ad

On WIndows only


 Define math constants for Visual Studio

cadb1cb

Like M_PI as mentioned in some examples


 Fix C4244 convertion warnings

616a1ea

See [Visual Studio Compiler Warning C4244](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-levels-3-and-4-c4244).