-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix issue lava/matplotlib-cpp#124#211
Merged
Merged
Conversation
lava
commented
Aug 27, 2020
Owner
Looks great, I didn't really do testing beyond "works on my machine" but it seems safe enough and hopefully fixes a real issue for many people.
Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix has been tested on Debian Buster with Python 3.7.3 and should not involve any regression I think (I hope).
After investigation, I found the problem was clearly the same situation explained in this post : https://stackoverflow.com/questions/42537291/embedding-python-with-c