-
Notifications
You must be signed in to change notification settings - Fork 153
Fix boolean parameter handling in ListRoutes MCP tool #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ListRoutes tool was throwing a type error when boolean parameters (except_vendor, only_vendor) were passed because str_replace() was being called on boolean values. This fix adds type checking to handle boolean parameters separately from string parameters. The error was: "str_replace(): Argument laravel#3 ($subject) must be of type array|string, true given" Boolean parameters are now properly passed to the artisan command without string manipulation, while string parameters continue to have wildcard characters sanitized.
The ListRoutes tool was throwing a type error when boolean parameters (except_vendor, only_vendor) were passed because str_replace() was being called on boolean values. This fix adds type checking to handle boolean parameters separately from string parameters. The error was: "str_replace(): Argument laravel#3 ($subject) must be of type array|string, true given" Boolean parameters are now properly passed to the artisan command without string manipulation, while string parameters continue to have wildcard characters sanitized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a type error when using boolean parameters (
except_vendor,only_vendor) with the ListRoutesMCP tool.
Problem
The tool was calling
str_replace()on boolean values, causing this error:str_replace(): Argument #3 ($subject) must be of type array|string, true given
Solution
Added type checking before string manipulation in
src/Mcp/Tools/ListRoutes.php:Testing
except_vendor => truenow works correctlymethod => "POST"still work as before