-
Notifications
You must be signed in to change notification settings - Fork 139
Updated access modifiers from private
to protected
across multiple files
#249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
I am developing a Laravel application, and JetBrains Junie provides very poor guidance for working with Laravel.
My idea is to connect Laravel Boost to the application being developed and generate guidelines for it.
My steps were as follows:
After that, I answered the questions and ended up with three guidelines: boost, foundation, and php.
All guidelines used by the project should be generated:
In addition, if you run the
boost:install
console command with the-n
parameter in this project, I get an error:Attempts to change behavior
I wanted to override some methods in the
Laravel\Boost\Console\InstallCommand
class but couldn't do so because they are private.Proposal
Therefore, I propose replacing private methods with protected ones so that we can work more flexibly with the project when developing packages for Laravel.
For now, I had to copy-paste the
Laravel\Boost\Console\InstallCommand
class into the project and make the necessary changes (one, two, three). This is very bad and inconvenient, but there was no other way.In conclusion
Yes, this solution is far from ideal, and yes, in some places it may mislead the AI. But it helps the AI better understand what it’s working with.