-
Notifications
You must be signed in to change notification settings - Fork 135
Fix Laravel 10 bootstrap/app.php Documentation Inaccuracy #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulschoeman
wants to merge
1
commit into
laravel:main
from
paulschoeman:fix/laravel-10-core-blade-inaccuracy
Open
Fix Laravel 10 bootstrap/app.php Documentation Inaccuracy #224
paulschoeman
wants to merge
1
commit into
laravel:main
from
paulschoeman:fix/laravel-10-core-blade-inaccuracy
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Laravel 10 core guidelines in
.ai/laravel/10/core.blade.php
contained an inaccurate statement claiming "There is nobootstrap/app.php
application configuration in Laravel 10". This is incorrect and misleading to Boost users working with Laravel 10 applications.What This Fixes
Before (Incorrect):
After (Accurate):
Impact on End Users
bootstrap/app.php
file doesn't existTechnical Details
Laravel 10 does have a
bootstrap/app.php
file, but it serves a foundational role:The configuration responsibilities remain in their traditional Laravel 10 locations:
app/Http/Kernel.php
app/Exceptions/Handler.php
app/Console/Kernel.php
Why This Matters
This inaccuracy could lead to:
bootstrap/app.php
fileBackward Compatibility
✅ This change does not break any existing functionality - it only corrects documentation to match Laravel 10's actual file structure.
Testing
This fix ensures Boost provides accurate, version-specific guidance that aligns with Laravel 10's actual architecture.