-
Notifications
You must be signed in to change notification settings - Fork 134
Ensure guideline file content ends with a newline #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+41
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@balu-lt
balu-lt
force-pushed
the
patch-1
branch
from
August 14, 2025 14:13
383c5cb
to
6522e47
Compare
nikspyratos
commented
Aug 18, 2025
Would it be worth expanding this PR to include doing this change for the mcp.json
files created/modified? I've come across this issue there too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial guideline file is generated without a newline at the end.
When additional custom rules are added, code editors like PhpStorm automatically append a newline, causing unnecessary GIT diffs.
This PR ensures that the generated guideline content always ends with a newline, preventing unwanted diffs and following common text file conventions.