Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Reduce allocs for bitmap index #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ulgut wants to merge 1 commit into lance-format:main
base: main
Choose a base branch
Loading
from ulgut:reduce-allocations-for-bitmap-index

Conversation

@ulgut
Copy link

@ulgut ulgut commented Dec 28, 2025
edited
Loading

Attempts to address #5494. This improves runtime during bitmap index creation. I'm currently looking to see whether we can group by value, then construct a sorted range all-at-once with from_sorted_iter. Only problem with this is whether we might accumulate the same # of allocs doing a group by on these unique values. In this case, push() optimization will not be needed.

Roaring bitmaps support RoaringBitmap::push API where the successive calls to the method contain data in monotonically increasing order. This replaces expensive RoaringBitmap::insert being called which:

  1. Does a binary search to find the appropriate container.
  2. Runs a linearVec::insert on this container (need to shuffle items around).

Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /