Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[pull] master from amejiarosario:master #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 5 commits into lalittolani:master from amejiarosario:master
Oct 4, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add examples to contributing
  • Loading branch information
amejiarosario committed Oct 4, 2020
commit f5169b540e62245f73c710d7643d61553c724cfb
36 changes: 7 additions & 29 deletions CONTRIBUTING.md
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,17 @@ to read on GitHub as well as in various git tools.

The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.


Examples:

```
docs(changelog): update changelog to beta.5
```
feat(heap): add error handling for heaps

BREAKING CHANGE: size is now an attribute rather than a method. Similar to the built-in Map.size and Set.size
```
fix(release): need to depend on latest rxjs and zone.js

The version in our package.json gets copied to the one we publish, and users need the latest of these.
```
fix(book/solutions): fix missing solutions
```

### Revert
Expand Down Expand Up @@ -184,31 +187,6 @@ Examples of breaking changes include:
* changing the side effects of using a particular API


## Generating Changelog

We use these three sections in changelog: new features, bug fixes, breaking changes.

List of all subjects (First lines in commit message) since last release:

```sh
git log <last tag> HEAD --pretty=format:%s

# example
git log 1.1.0..HEAD --pretty=format:%s
```

New features in this release

```sh
git log <last release> HEAD --grep feat

# examples
git log 1.2.0..HEAD --pretty=format:"- %s [commit](https://github.com/amejiarosario/dsa.js/commit/%H)" --grep "BREAKING CHANGE:"
git log 1.2.0..HEAD --pretty=format:"- %s [commit](https://github.com/amejiarosario/dsa.js/commit/%H)" --grep "^feat\S*:"
git log 1.2.0..HEAD --pretty=format:"- %s [commit](https://github.com/amejiarosario/dsa.js/commit/%H)" --grep "^fix\S*:"
```


<!-- Examples -->
<!-- https://github.com/nodejs/node/blob/v12.0.0/COLLABORATOR_GUIDE.md -->
<!-- https://github.com/nodejs/node/blob/v12.0.0/doc/guides/writing-and-running-benchmarks.md -->
2 changes: 1 addition & 1 deletion notes.md
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ and the meaning the the following:
- Minor: Features (new functionality, adding new topics)
- Patch: Fixes (bug fixes, typos, etc.)

# Generating Changelog
# Generating Changelog (manually) [deprecated]

We use these three sections in changelog: new features, bug fixes, breaking changes.

Expand Down

AltStyle によって変換されたページ (->オリジナル) /